This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Mail\Message::getSubject() should return value the way it was set #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return null; | ||
| } | ||
| $header = $headers->get('subject'); | ||
| return $header->getFieldValue(HeaderInterface::FORMAT_ENCODED); |
There was a problem hiding this comment.
Should this also be done for SMTP and/or File transports? or is it an issue only for the Sendmail transport?
There was a problem hiding this comment.
Message::getSubject() was used only in sendmail.
I will check if getters for other properties proxied to Headers are used in transports and replace them with direct access too.
ghost
assigned 
|
Merged to master and release branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message return subject in encoded form which is quite unexpected behaviour for end user
Transport should retrieve encoded Subject header value from headers and not directly from message object.